mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64924: Fixed the broken GRPC build.
Date Wed, 03 Jan 2018 20:02:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64924/#review194710
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Jan. 3, 2018, 7:55 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64924/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 7:55 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `upgradeResources` to the `resources_utils.hpp`, and a silly
> mistake around using `foreach` over a protobuf mutable repeated field.
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.hpp 115efc2868be3deab7af3f9a30dd26ca3c49a8a6 
>   src/resource_provider/storage/provider.cpp e2608723af0ef9955e46da300254306497d2d6df

> 
> 
> Diff: https://reviews.apache.org/r/64924/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message