mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64868: Added initial doc about CSI support in Mesos.
Date Wed, 03 Jan 2018 00:30:22 GMT


> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote:
> > docs/csi.md
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line137>
> >
> >     > Any disk resource ... inherits the same profile as the storage pool.
> >     
> >     Why, and who enforces this? Is this because a single logical pool may have multiple,
virtual representations (one per profile)? If so it might be worth differentiating between
a logical pool and a virtual one.

I don't want to overcomplicate here. I think the definition is pretty clear "A RAW disk resource
not backed by a CSI volume is referred to as a storage pool". There's a TODO below capture
the explanation of correlated resources, which will probably clarify that.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64868/#review194600
-----------------------------------------------------------


On Dec. 29, 2017, 4:53 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64868/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2017, 4:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann,
Joseph Wu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial doc about CSI support in Mesos.
> 
> 
> Diffs
> -----
> 
>   docs/csi.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64868/diff/2/
> 
> 
> Testing
> -------
> 
> The rendering can be checked here:
> https://github.com/jieyu/mesos/blob/csi_doc/docs/csi.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message