mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.
Date Tue, 02 Jan 2018 23:34:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63976/
-----------------------------------------------------------

(Updated Jan. 2, 2018, 3:34 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Set required fields in `TaskInfo`.


Bugs: MESOS-8221
    https://issues.apache.org/jira/browse/MESOS-8221


Repository: mesos


Description
-------

Previously, our `downgradeResources` function only took a pointer to
`RepeatedPtrField<Resource>`. This wasn't great since we needed manually
invoke `downgradeResources` on every `Resource`s field of every message.

This patch makes it such that `downgradeResources` can take any
`protobuf::Message` or `protobuf::RepeatedPtrField<Resource>`.


Diffs (updated)
-----

  src/common/resources_utils.hpp 5b74ff2dd3ecb1a0101671d11ea10e29a43524b0 
  src/common/resources_utils.cpp 47ba885517bdfef4764deb0826e13538ce529902 
  src/tests/resources_tests.cpp 64bde85e0e7f0bd395189eb6a8635383095b2f07 


Diff: https://reviews.apache.org/r/63976/diff/4/

Changes: https://reviews.apache.org/r/63976/diff/3-4/


Testing
-------

Added new tests + `make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message