Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8A61B200D5A for ; Thu, 14 Dec 2017 11:35:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 88D46160C04; Thu, 14 Dec 2017 10:35:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF55B160C01 for ; Thu, 14 Dec 2017 11:35:53 +0100 (CET) Received: (qmail 17819 invoked by uid 500); 14 Dec 2017 10:35:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17798 invoked by uid 99); 14 Dec 2017 10:35:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2017 10:35:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 412E71A0458; Thu, 14 Dec 2017 10:35:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id is2KAvOrHBKX; Thu, 14 Dec 2017 10:35:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 650FF5F39F; Thu, 14 Dec 2017 10:35:50 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6694E015F; Thu, 14 Dec 2017 10:35:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8A7CBC4004D; Thu, 14 Dec 2017 10:35:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8160660951385834117==" MIME-Version: 1.0 Subject: Re: Review Request 64546: Fixed a flaky test. From: Jan Schlicht To: Benjamin Bannier , Jie Yu , Alexander Rukletsov Cc: Mesos Reviewbot Windows , Jan Schlicht , mesos Date: Thu, 14 Dec 2017 10:35:49 -0000 Message-ID: <20171214103549.49843.94149@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64546/ X-Sender: Jan Schlicht References: <20171212151559.27607.66385@reviews-vm2.apache.org> In-Reply-To: <20171212151559.27607.66385@reviews-vm2.apache.org> Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos archived-at: Thu, 14 Dec 2017 10:35:54 -0000 --===============8160660951385834117== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64546/ ----------------------------------------------------------- (Updated Dec. 14, 2017, 11:35 a.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu. Changes ------- Addressed issues. Bugs: MESOS-8315 https://issues.apache.org/jira/browse/MESOS-8315 Repository: mesos Description (updated) ------- Callbacks of already invalidated instances could be called in 'ResubscribeResourceProvider' when simulating a resource provider restart. This has been resolved by not only restart a resource provider's driver, but creating a new 'MockResourceProvider' instance. Diffs (updated) ----- src/tests/resource_provider_manager_tests.cpp 41fc4ea592eed49bd03d7e78019fa647f4f6e652 Diff: https://reviews.apache.org/r/64546/diff/2/ Changes: https://reviews.apache.org/r/64546/diff/1-2/ Testing ------- make check src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background) Thanks, Jan Schlicht --===============8160660951385834117==--