Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============9198602308427698222=="
MIME-Version: 1.0
Subject: Re: Review Request 64387: Windows: Ported docker health check tests.
From: Akash Gupta <akash-gupta@hotmail.com>
To: Jie Yu <yujie.jay@gmail.com>, Joseph Wu <joseph@mesosphere.io>,
 Andrew Schwartzmeyer <andrew@schwartzmeyer.com>,
 Michael Park <mpark@apache.org>
Cc: Akash Gupta <akash-gupta@hotmail.com>, mesos <reviews@mesos.apache.org>
Date: Wed, 13 Dec 2017 01:48:45 -0000
Message-ID: <20171213014845.6617.46447@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Akash Gupta <noreply@reviews.apache.org>
References: <20171207223044.36753.79768@reviews-vm2.apache.org>
In-Reply-To: <20171207223044.36753.79768@reviews-vm2.apache.org>
Reply-To: Akash Gupta <akash-gupta@hotmail.com>
archived-at: Wed, 13 Dec 2017 01:48:51 -0000

--===============9198602308427698222==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/
-----------------------------------------------------------

(Updated Dec. 13, 2017, 1:48 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased + addressed Andy's feedback.


Repository: mesos


Description
-------

The `HealthCheckTest.ROOT_DOCKER_*` and
`DockerContainerizerHealthCheckTest.*` tests now work on Windows.


Diffs (updated)
-----

  src/tests/environment.cpp 72bd621f02f97ea5fd553f3dc0bd52adb8ddee8f 
  src/tests/health_check_tests.cpp bb909c5ea4a51b562ac753083fda002195ac08ad 
  src/tests/mesos.hpp 320e9755c73bcf19ba8ac87f2081f17fdaa438ea 


Diff: https://reviews.apache.org/r/64387/diff/2/

Changes: https://reviews.apache.org/r/64387/diff/1-2/


Testing (updated)
-------

Windows Server:
[==========] Running 5 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from HealthCheckTest
[ RUN      ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[       OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
[ RUN      ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
[       OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
[----------] 2 tests from HealthCheckTest (44835 ms total)

[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
[ RUN      ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
[       OK ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0 (28487 ms)
[ RUN      ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
[       OK ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0 (26447 ms)
[ RUN      ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
[       OK ] NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0 (26264 ms)
[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest (81268 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 2 test cases ran. (126559 ms total)
[  PASSED  ] 5 tests

Rest of tests pass.

Windows Client (Disabled network health checks):
Proof that network health checks are skipped on Windows Client.
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from daemon: sharing of hyperv containers network is not supported.
356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
-------------------------------------------------------------
We cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of Windows.

Rest rests pass.

Linux:
make check passes


Thanks,

Akash Gupta


--===============9198602308427698222==--