Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============5997415788946158381=="
MIME-Version: 1.0
Subject: Re: Review Request 64436: Toggled the authenticate_http_readwrite
 flag in MesosTest.
From: Mesos Reviewbot Windows <reviews@mesos.apache.org>
To: Greg Mann <greg@mesosphere.io>
Cc: Mesos Reviewbot Windows <reviews@mesos.apache.org>,
 James Peach <jpeach@apache.org>, mesos <reviews@mesos.apache.org>
Date: Fri, 08 Dec 2017 15:39:50 -0000
Message-ID: <20171208153950.33513.44243@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Mesos Reviewbot Windows <noreply@reviews.apache.org>
References: <20171208012616.36753.55617@reviews-vm2.apache.org>
In-Reply-To: <20171208012616.36753.55617@reviews-vm2.apache.org>
Reply-To: Mesos Reviewbot Windows <reviews@mesos.apache.org>
archived-at: Fri, 08 Dec 2017 15:39:58 -0000

--===============5997415788946158381==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64436/#review193253
-----------------------------------------------------------


FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['64436']`

Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64436

Relevant logs:

- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64436/logs/libprocess-tests-stdout.log):

```
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (17132 ms)
[ RUN      ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16340 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (34748 ms total)

[----------] Global test environment tear-down
[==========] 223 tests from 35 test cases ran. (263253 ms total)
[  PASSED  ] 209 tests.
[  FAILED  ] 14 tests, listed below:
[  FAILED  ] SSLTest.SSLSocket
[  FAILED  ] SSLTest.NonSSLSocket
[  FAILED  ] SSLTest.NoVerifyBadCA
[  FAILED  ] SSLTest.RequireBadCA
[  FAILED  ] SSLTest.VerifyBadCA
[  FAILED  ] SSLTest.VerifyCertificate
[  FAILED  ] SSLTest.ProtocolMismatch
[  FAILED  ] SSLTest.ECDHESupport
[  FAILED  ] SSLTest.ValidDowngrade
[  FAILED  ] SSLTest.NoValidDowngrade
[  FAILED  ] SSLTest.ValidDowngradeEachProtocol
[  FAILED  ] SSLTest.NoValidDowngradeEachProtocol
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false"
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"

14 FAILED TESTS
  YOU HAVE 19 DISABLED TESTS

```

- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64436/logs/libprocess-tests-stderr.log):

```
I1208 15:38:40.769349  9388 process.cpp:887] Failed to accept socket: future discarded
I1208 15:38:40.959158  2228 process.cpp:887] Failed to accept socket: future discarded
I1208 15:38:41.736188  1272 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 15:38:41.737188  1272 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 15:38:41.737188  1272 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\c6ZklQ\cert.pem
I1208 15:38:41.737188  1272 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\c6ZklQ
I1208 15:38:42.194206  1272 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 15:38:42.194206  1272 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 15:38:42.194206  1272 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 15:38:42.215207  1272 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\dZ5jsk\cert.pem
I1208 15:38:42.215207  1272 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\dZ5jsk
I1208 15:38:43.330569  1272 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 15:38:43.330569  1272 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 15:38:43.330569  1272 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 15:38:43.331568  1272 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\lRLJI7\cert.pem
I1208 15:38:59.717869  1272 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 15:38:59.717869  1272 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 15:38:59.718869  1272 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 15:38:59.718869  1272 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 15:38:59.718869  1272 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\sVPIJk\cert.pem
I1208 15:39:15.836845  8180 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 8, 2017, 1:26 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64436/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 1:26 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor authentication mechanism depends on SSL support
> being enabled in the build. Multiple tests that invoke the default
> executor have compilation time checks for SSL support so they
> can disable the Mesos agent authenticate_http_readwrite flag in
> this case.  Rather than duplicating this check to multiple tests,
> set it to an appropriate default in the MesosTest fixture.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa 
>   src/tests/check_tests.cpp 2a71f41bad1a7eea2763addf5fc35d648bd46cc6 
>   src/tests/container_daemon_tests.cpp 6e5efc952edeab0a03b33dcff81fec484126d068 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp fd1cd468bd1e4c2455bb3315b085d38b2543bc6f 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp d3c456826db2c1844ebfd55acbd766d6fb7eaede 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445 
>   src/tests/containerizer/ports_isolator_tests.cpp 343803028afce01874a054879f5ec39f2b85286a 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp f639cac900f8ac5d0bc2eb856e90cb4881d85ec3 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 271bbbe71f16388d1331a9db120ba71b86cefa5f 
>   src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a 
>   src/tests/health_check_tests.cpp 56721fac4a464f3cad40dbf4e6bc4fb7b1a780d4 
>   src/tests/master_slave_reconciliation_tests.cpp 1a9b40a9a269313fc6c858ab5b2a9901c5e12352 
>   src/tests/master_tests.cpp 0dfa8c716bc35a386dd7fa87b595360487ab8b15 
>   src/tests/mesos.cpp 7ed08a5ac2a0efdbd2a93fb48a70a23d0973dc51 
>   src/tests/scheduler_tests.cpp ecfce4d112464a76c14603e40c20585ec25e0ca7 
> 
> 
> Diff: https://reviews.apache.org/r/64436/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


--===============5997415788946158381==--