Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4729B200D51 for ; Fri, 8 Dec 2017 03:44:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 45B70160C1E; Fri, 8 Dec 2017 02:44:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8C4EC160C0C for ; Fri, 8 Dec 2017 03:44:44 +0100 (CET) Received: (qmail 73131 invoked by uid 500); 8 Dec 2017 02:44:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 73119 invoked by uid 99); 8 Dec 2017 02:44:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 02:44:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CF469C80CC; Fri, 8 Dec 2017 02:44:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.991 X-Spam-Level: ** X-Spam-Status: No, score=2.991 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1e7ragndetyy; Fri, 8 Dec 2017 02:44:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1A67E62C64; Fri, 8 Dec 2017 02:44:41 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5EE31E0237; Fri, 8 Dec 2017 02:44:40 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 49E02C40017; Fri, 8 Dec 2017 02:44:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2306837528480490763==" MIME-Version: 1.0 Subject: Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility. From: Jeff Coffler To: Li Li , John Kordich , Joseph Wu , Andrew Schwartzmeyer , Michael Park Cc: Jeff Coffler , mesos , Jie Yu Date: Fri, 08 Dec 2017 02:44:40 -0000 Message-ID: <20171208024440.14726.5492@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jeff Coffler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60626/ X-Sender: Jeff Coffler References: <20171106180934.31729.5286@reviews-vm2.apache.org> In-Reply-To: <20171106180934.31729.5286@reviews-vm2.apache.org> Reply-To: Jeff Coffler X-ReviewRequest-Repository: mesos archived-at: Fri, 08 Dec 2017 02:44:45 -0000 --===============2306837528480490763== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ ----------------------------------------------------------- (Updated Dec. 8, 2017, 2:44 a.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael Park. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description ------- Windows doesn't support os::shell calls, so reworked the code to use libprocess instead. Diffs (updated) ----- src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4 Diff: https://reviews.apache.org/r/60626/diff/7/ Changes: https://reviews.apache.org/r/60626/diff/6-7/ Testing ------- See upstream Thanks, Jeff Coffler --===============2306837528480490763==--