mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 64546: Fixed a flaky test.
Date Thu, 14 Dec 2017 10:35:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/
-----------------------------------------------------------

(Updated Dec. 14, 2017, 11:35 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.


Changes
-------

Addressed issues.


Bugs: MESOS-8315
    https://issues.apache.org/jira/browse/MESOS-8315


Repository: mesos


Description (updated)
-------

Callbacks of already invalidated instances could be called in
'ResubscribeResourceProvider' when simulating a resource provider
restart. This has been resolved by not only restart a resource
provider's driver, but creating a new 'MockResourceProvider' instance.


Diffs (updated)
-----

  src/tests/resource_provider_manager_tests.cpp 41fc4ea592eed49bd03d7e78019fa647f4f6e652 


Diff: https://reviews.apache.org/r/64546/diff/2/

Changes: https://reviews.apache.org/r/64546/diff/1-2/


Testing
-------

make check

src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider*
--gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message