mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 64589: Fixed a bug related to offer operation application in the agent.
Date Thu, 14 Dec 2017 01:38:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64589/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.


Repository: mesos


Description
-------

The bug is introduced in this patch:
https://reviews.apache.org/r/64477/

Given that we also keep track of each resource provider's total
resources in addition to the total resources of the agent, we need to
make sure we update those totals after applying an operation.

The bug may manifest as a CHECK failure in the agent that checks if
`totalResources` of the agent is a super set of all the resource
provider resources.


Diffs
-----

  src/slave/slave.hpp de2b2e2e81ed860e6a33ce1b93d859d816ba1021 
  src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d 


Diff: https://reviews.apache.org/r/64589/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message