mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states.
Date Wed, 13 Dec 2017 22:51:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64559/#review193744
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/resource_provider/storage/provider.cpp
Lines 2080-2081 (original), 2099-2100 (patched)
<https://reviews.apache.org/r/64559/#comment272374>

    I don't quite get this. Why we need to have this check in this function?



src/resource_provider/storage/provider.cpp
Line 2436 (original), 2397 (patched)
<https://reviews.apache.org/r/64559/#comment272375>

    remove the extra space


- Jie Yu


On Dec. 13, 2017, 2:59 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64559/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2017, 2:59 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of checkpointing `ApplyOfferOperation`, we now checkpoint
> `OfferOperations` in resource provider states such that we can keep
> track of completed operations as well.
> 
> This patch also does some code cleanup, and modifies a unit test for
> storage local resource provider to issue operations in batches.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/state.proto 321201e0aee9c104e831a6fa91f737216d8cd59a 
>   src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435

>   src/tests/storage_local_resource_provider_tests.cpp e5868bfcb71977d2b2a146865f12a5207010ae40

> 
> 
> Diff: https://reviews.apache.org/r/64559/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message