mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`.
Date Wed, 13 Dec 2017 10:51:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64514/#review193664
-----------------------------------------------------------


Ship it!





src/master/master.hpp
Lines 784-785 (patched)
<https://reviews.apache.org/r/64514/#comment272250>

    I'm face with a conundrum, should this follow the patter of the other authorization methods
and use Doxygen, or should it follow the pattern of the rest of the file?
    
    I'll let it up to you.


- Alexander Rojas


On Dec. 12, 2017, 1:30 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64514/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 1:30 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and James Peach.
> 
> 
> Bugs: MESOS-8306
>     https://issues.apache.org/jira/browse/MESOS-8306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows us to authorize static resource reservations that don't
> come from `Offer::Operation::Reserve`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 232cc3758f240db626c4fdaf852163fa48af4dd7 
>   src/master/master.cpp b10d0341276090bfa70aaa4fd6317a560e3334ea 
> 
> 
> Diff: https://reviews.apache.org/r/64514/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message