mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 64507: Added a master flag to disallow agents without domain.
Date Mon, 11 Dec 2017 20:26:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64507/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-8115
    https://issues.apache.org/jira/browse/MESOS-8115


Repository: mesos


Description
-------

Added a new `--require_agent_domains` flag and implementation. When
set to true, it will cause the master to refuse (re-)registration
attempts for agents with no configured domain.

This is intended as a safety net for operators, who could forget to
configure the fault domain of a remote agent and let it join the
cluster. If this happens, an agent in a remote region will be
considered a local agent by the master and frameworks (because agent's fault domain is not
configured), causing tasks to potentially land in a remote agent which is undesirable.


Diffs
-----

  docs/configuration/master.md 6af16a08257680963884d07a325803487f677c37 
  src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec 
  src/master/flags.cpp 18f405b7e9cc6bd0011284b631974eee52dd2bf3 
  src/master/master.cpp b3e074cfe86600793310deb87932fa145e95055d 
  src/tests/master_tests.cpp 7b087675200fe0ca69319b715997700a91d9f6b2 


Diff: https://reviews.apache.org/r/64507/diff/1/


Testing
-------

`make check`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message