mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64423: Explicitly passed resource-provider information in 'UpdateSlaveMessage'.
Date Fri, 08 Dec 2017 11:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64423/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 12:32 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Addressed Jie's comment.


Summary (updated)
-----------------

Explicitly passed resource-provider information in 'UpdateSlaveMessage'.


Bugs: MESOS-8312
    https://issues.apache.org/jira/browse/MESOS-8312


Repository: mesos


Description (updated)
-------

This patch changes the way resource-provider related information is
passed. Instead of aggregating all information from both the agent and
resource providers into global per-agent lists in
'UpdateSlaveMessage', with this patch we pass resource-provider
related information explicitly. We can in a subsequent patch surface
this information in e.g., the operator API.


Diffs (updated)
-----

  src/master/master.hpp 1f5daae6abbf81cd5fc0341f5ee6c9678beb0d64 
  src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
  src/slave/slave.hpp 5cb0d55970e50c5b8b5ef9c43f2967f4663a7781 
  src/slave/slave.cpp 54d8bcc035227dd6896ffa6e692a91749c0b56a6 
  src/tests/slave_tests.cpp 07145432c35c85a755b66ba575c2a46db072ce5c 


Diff: https://reviews.apache.org/r/64423/diff/3/

Changes: https://reviews.apache.org/r/64423/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message