mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63390: Unit tests for storage local resource provider.
Date Thu, 07 Dec 2017 20:48:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 8:48 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

`DESTROY` before `DESTROY_VOLUME` and bypass `DESTROY` validation for provider resources.


Repository: mesos


Description
-------

This patche adds two unit tests. The first one will register a framework
to issue a `CREATE_VOLUME` then a `DESTROY_VOLUME` call to destroy
an unpublised volume. The second one will register a framework to issue
`CREATE_VOLUME`, `CREATE`, `LAUNCH`, `DESTROY_VOLUME` in sequence to
create a volume and launch a task to use a persistent volume on the CSI
volume, then destroy this published volume.


Diffs (updated)
-----

  src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770 
  src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53 
  src/master/validation.cpp bf7ae65cad79c14f11e1858a16bd6d1b2f7745e7 
  src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
  src/tests/storage_local_resource_provider_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63390/diff/8/

Changes: https://reviews.apache.org/r/63390/diff/7-8/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message