mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.
Date Tue, 05 Dec 2017 19:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192911
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 5, 2017, 7:03 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 7:03 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
> 
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 41ffe17def133d7e735afa26a6fedd154e51f4b4

>   src/master/allocator/mesos/hierarchical.cpp 4428541e63561f7c3bc3bc61f4b47e35216f6442

>   src/master/master.hpp 448be3b4a3eb3d0cbd34a39b19640d15cf3fc2af 
>   src/master/master.cpp 31991b5f7f7f4e7dc73d71a3160348bfc0a627c3 
>   src/tests/hierarchical_allocator_tests.cpp 154049c47f2dae2df8d1bb4ddb5c48c478bb3d0e

> 
> 
> Diff: https://reviews.apache.org/r/64011/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message