mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().
Date Mon, 04 Dec 2017 21:36:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/#review192767
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/allocator/allocator.hpp
Line 210 (original), 211 (patched)
<https://reviews.apache.org/r/64010/#comment271020>

    Can you add a TODO to make `total` and `capabilities` non-optional too?



src/master/allocator/mesos/hierarchical.hpp
Lines 386 (patched)
<https://reviews.apache.org/r/64010/#comment271021>

    s/domain/host/


- Vinod Kone


On Dec. 4, 2017, 4:29 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64010/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 4:29 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is done mainly in preparation for the upcoming agent
> reconfiguration patches, where it will become possible that
> `updateSlave()` is passed a different SlaveInfo than `addSlave()`,
> and schedulers who rely on some fields in it for their scheduling
> decisions need to be able to check and compare them.
> 
> Additionally, the HierarchicalDRFAllocator was changed to store
> the full SlaveInfo for every slave instead of storing domain and
> hostname separately.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp acb9e4f6a843e64c915c43c218d8a533ca63333b 
>   src/master/allocator/mesos/allocator.hpp 48254b6e0974bdc16ffda04d3d271538048d3206 
>   src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76

>   src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1

>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
>   src/tests/allocator.hpp fc5d9efc8dab3bd971fa8938e3f82e8291c4ab9d 
>   src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee

> 
> 
> Diff: https://reviews.apache.org/r/64010/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2299/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message