mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.
Date Mon, 04 Dec 2017 19:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63498/#review192737
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Line 1367 (original), 1367-1368 (patched)
<https://reviews.apache.org/r/63498/#comment270995>

    This might break some toolings. Let's call out this in the CHANGELOG and upgrade.md.


- Jie Yu


On Nov. 4, 2017, 1:13 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63498/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2017, 1:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7550
>     https://issues.apache.org/jira/browse/MESOS-7550
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the `root` field is set to a relative path, it would mean that the
> path is relative to the agent work directory. This provides the ability
> for an isolator to construct the mount point of a CSI volume without
> knowing the resource provider info.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 68a5538904b601a91a40db68cebde96f74a2f160 
>   include/mesos/v1/mesos.proto c46cec78db63dc3714e357a954a4e7bf080485fd 
>   src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 
>   src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 
> 
> 
> Diff: https://reviews.apache.org/r/63498/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message