mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.
Date Fri, 01 Dec 2017 11:20:33 GMT


> On Dec. 1, 2017, 1:30 a.m., Alexander Rojas wrote:
> > This patch didn't add tests in [authorization_tests.cpp](https://github.com/apache/mesos/blob/master/src/tests/authorization_tests.cpp)

Yeah, I have the tests up for review separately: https://reviews.apache.org/r/63828/ (which
you've already reviewed ;)


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60891/#review192455
-----------------------------------------------------------


On Nov. 13, 2017, 5:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60891/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2017, 5:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This defines some coarse-grained AuthZ for launching and managing
> standalone containers.  Each HTTP principal can be given the right
> to Launch, Wait upon, Kill, or Remove standalone containers under
> a given (posix) user.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 587b71489730f9a1252c73c0239e3d9892b3ae8e 
>   include/mesos/authorizer/authorizer.proto 87a805794f430fc8b2e47de6d624b95deef162b4

>   src/authorizer/local/authorizer.cpp 2fe7b879e649b13322cfcb300c21ef1ed0fea410 
> 
> 
> Diff: https://reviews.apache.org/r/60891/diff/5/
> 
> 
> Testing
> -------
> 
> See later in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message