mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64158: Used helper functions instead of switches for resource extraction.
Date Fri, 01 Dec 2017 11:03:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64158/#review192462
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Jan! Will fix minor style nits while committing.


src/master/master.hpp
Line 2836 (original), 2813 (patched)
<https://reviews.apache.org/r/64158/#comment270612>

    We pull `&` to the type.



src/master/master.hpp
Line 2897 (original), 2859 (patched)
<https://reviews.apache.org/r/64158/#comment270613>

    We pull `&` to the type.


- Benjamin Bannier


On Nov. 29, 2017, 2:52 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64158/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Depeding on the type of an offer operation, different resource need
> to be extracted from an operation. Instead of using a switch, the helper
> functions 'isSpeculativeOperation' and 'getConsumedResources' are used
> instead.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
>   src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
> 
> 
> Diff: https://reviews.apache.org/r/64158/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message