Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90A49200D48 for ; Wed, 29 Nov 2017 19:06:29 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8F552160C04; Wed, 29 Nov 2017 18:06:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D63C0160C02 for ; Wed, 29 Nov 2017 19:06:28 +0100 (CET) Received: (qmail 82964 invoked by uid 500); 29 Nov 2017 18:06:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 82391 invoked by uid 99); 29 Nov 2017 18:06:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Nov 2017 18:06:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C69C3180796; Wed, 29 Nov 2017 18:06:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WEanBjcOiikf; Wed, 29 Nov 2017 18:06:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9DA305F477; Wed, 29 Nov 2017 18:06:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 485A3E012B; Wed, 29 Nov 2017 18:06:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 33BC4C40098; Wed, 29 Nov 2017 18:06:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3402715942913073919==" MIME-Version: 1.0 Subject: Re: Review Request 64009: Added new UpdateSlave registry operation. From: Benno Evers To: Benjamin Mahler , Michael Park , Vinod Kone Cc: Benno Evers , mesos Date: Wed, 29 Nov 2017 18:06:25 -0000 Message-ID: <20171129180625.35988.28005@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64009/ X-Sender: Benno Evers References: <20171127235607.34370.94021@reviews-vm2.apache.org> In-Reply-To: <20171127235607.34370.94021@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/master/registry_operations.hpp X-ReviewBoard-Diff-For: src/master/registry_operations.cpp Reply-To: Benno Evers X-ReviewRequest-Repository: mesos archived-at: Wed, 29 Nov 2017 18:06:29 -0000 --===============3402715942913073919== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ ----------------------------------------------------------- (Updated Nov. 29, 2017, 6:06 p.m.) Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone. Repository: mesos Description ------- This operation can be used to update the stored state of an existing, admitted slave. Diffs (updated) ----- src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b src/master/registry_operations.hpp PRE-CREATION src/master/registry_operations.cpp PRE-CREATION src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 Diff: https://reviews.apache.org/r/64009/diff/4/ Changes: https://reviews.apache.org/r/64009/diff/3-4/ Testing ------- Thanks, Benno Evers --===============3402715942913073919==--