Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A7B0C200D5B for ; Wed, 29 Nov 2017 01:55:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A64B3160C15; Wed, 29 Nov 2017 00:55:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EBB18160BE7 for ; Wed, 29 Nov 2017 01:55:01 +0100 (CET) Received: (qmail 90875 invoked by uid 500); 29 Nov 2017 00:55:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 90836 invoked by uid 99); 29 Nov 2017 00:55:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Nov 2017 00:55:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DF51EC4449; Wed, 29 Nov 2017 00:54:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.392 X-Spam-Level: **** X-Spam-Status: No, score=4.392 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KB_WAM_FROM_NAME_SINGLEWORD=0.2, NML_ADSP_CUSTOM_MED=1.2, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Vh16IIXCwgGm; Wed, 29 Nov 2017 00:54:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 385B35F239; Wed, 29 Nov 2017 00:54:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8AA54E0140; Wed, 29 Nov 2017 00:54:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EF3D2C4000C; Wed, 29 Nov 2017 00:54:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0234515707215314132==" MIME-Version: 1.0 Subject: Re: Review Request 64000: Added generic stringification of hashmap of stringifiable types. From: Jie Yu To: haosdent huang , Alexander Rukletsov Cc: Benjamin Bannier , Jie Yu , mesos Date: Wed, 29 Nov 2017 00:54:56 -0000 Message-ID: <20171129005456.26325.15804@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64000/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20171128213207.26589.44450@reviews-vm2.apache.org> In-Reply-To: <20171128213207.26589.44450@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jie Yu X-ReviewRequest-Repository: mesos archived-at: Wed, 29 Nov 2017 00:55:02 -0000 --===============0234515707215314132== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64000/#review192086 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On Nov. 28, 2017, 9:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64000/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 9:32 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > This patch adds generic stringification for hashmaps of stringifiable > types to stout. Related, but less generic functions are currently > implemented in both 'v1/mesos.hpp' and 'v1/type_utils.hpp'; these > implementations will be removed in a subsequent commit. > > > Diffs > ----- > > 3rdparty/stout/include/stout/hashmap.hpp faf8002f67c1385234fc18602e3cd6bdf47a3c34 > > > Diff: https://reviews.apache.org/r/64000/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============0234515707215314132==--