Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 95932200D4A for ; Tue, 28 Nov 2017 22:32:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 93F74160C07; Tue, 28 Nov 2017 21:32:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DB1F7160BE7 for ; Tue, 28 Nov 2017 22:32:07 +0100 (CET) Received: (qmail 28091 invoked by uid 500); 28 Nov 2017 21:32:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28080 invoked by uid 99); 28 Nov 2017 21:32:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 21:32:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 02ECB1A13D9; Tue, 28 Nov 2017 21:32:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qivoQ0o5ScKQ; Tue, 28 Nov 2017 21:32:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0336C5F19D; Tue, 28 Nov 2017 21:32:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4BB29E015F; Tue, 28 Nov 2017 21:32:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 379A2C4000C; Tue, 28 Nov 2017 21:32:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3420407268735852650==" MIME-Version: 1.0 Subject: Re: Review Request 63997: Added a new allocator method to add resources to agents. From: Benjamin Bannier To: Jie Yu , Benjamin Mahler Cc: Benjamin Bannier , mesos Date: Tue, 28 Nov 2017 21:32:03 -0000 Message-ID: <20171128213203.26589.65360@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63997/ X-Sender: Benjamin Bannier References: <20171127145550.9185.42385@reviews-vm2.apache.org> In-Reply-To: <20171127145550.9185.42385@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos archived-at: Tue, 28 Nov 2017 21:32:08 -0000 --===============3420407268735852650== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/ ----------------------------------------------------------- (Updated Nov. 28, 2017, 10:32 p.m.) Review request for mesos, Benjamin Mahler and Jie Yu. Changes ------- Addressed comments from bmahler. Repository: mesos Description ------- The added method complements 'Allocator::addSlave'. While in 'addSlave' the total agent resources and used resources are passed, the method 'addResourceProvider' added here allows to add additional, potentially used resources to an existing agent. Diffs (updated) ----- include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3 src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff Diff: https://reviews.apache.org/r/63997/diff/4/ Changes: https://reviews.apache.org/r/63997/diff/3-4/ Testing ------- `make check` Thanks, Benjamin Bannier --===============3420407268735852650==--