Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============2470834716530152193=="
MIME-Version: 1.0
Subject: Re: Review Request 62762: Added `LocalResourceProvider::principal()`
 for authentication.
From: Chun-Hung Hsiao <chhsiao@mesosphere.io>
To: Jie Yu <yujie.jay@gmail.com>, Alexander Rojas <alexander@mesosphere.io>,
 Joseph Wu <joseph@mesosphere.io>, Greg Mann <greg@mesosphere.io>
Cc: Chun-Hung Hsiao <chhsiao@mesosphere.io>, mesos <reviews@mesos.apache.org>
Date: Thu, 23 Nov 2017 09:41:52 -0000
Message-ID: <20171123094152.29235.28898@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Chun-Hung Hsiao <noreply@reviews.apache.org>
References: <20171122031010.49374.96987@reviews-vm2.apache.org>
In-Reply-To: <20171122031010.49374.96987@reviews-vm2.apache.org>
Reply-To: Chun-Hung Hsiao <chhsiao@mesosphere.io>
archived-at: Thu, 23 Nov 2017 09:41:57 -0000

--===============2470834716530152193==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62762/
-----------------------------------------------------------

(Updated Nov. 23, 2017, 9:41 a.m.)


Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu.


Changes
-------

Addressed some of jieyu's comments.


Bugs: MESOS-8100
    https://issues.apache.org/jira/browse/MESOS-8100


Repository: mesos


Description
-------

The `LocalResourceProvider::principal()` function takes a
`ResourceProviderInfo` and generates a principal with the following
claim:

  {"cid_prefix", <type-with-dots-replaced-by-dashes>-<name>--}

For example, for resource provider with type
'org.apache.mesos.rp.local.storage' and name 'foo', the claim would be:

  {"cid_prefix", "org-apache-mesos-rp-local-storage-foo--"}

In the future, we could add more claims for authorizing other
operations, such as authorization for Resource Provider API.


Diffs (updated)
-----

  src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f 
  src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da 
  src/resource_provider/storage/provider.hpp 6de88c2329b358fcf48bc39ddda0132170991c3c 
  src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f 


Diff: https://reviews.apache.org/r/62762/diff/9/

Changes: https://reviews.apache.org/r/62762/diff/8-9/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


--===============2470834716530152193==--