Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============7461391204900782936=="
MIME-Version: 1.0
Subject: Re: Review Request 62762: Added `LocalResourceProvider::principal()`
 for authentication.
From: Jie Yu <yujie.jay@gmail.com>
To: Jie Yu <yujie.jay@gmail.com>, Alexander Rojas <alexander@mesosphere.io>,
 Joseph Wu <joseph@mesosphere.io>, Greg Mann <greg@mesosphere.io>
Cc: Chun-Hung Hsiao <chhsiao@mesosphere.io>, mesos <reviews@mesos.apache.org>
Date: Thu, 23 Nov 2017 05:27:41 -0000
Message-ID: <20171123052741.55922.16753@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Jie Yu <noreply@reviews.apache.org>
References: <20171122031010.49374.96987@reviews-vm2.apache.org>
In-Reply-To: <20171122031010.49374.96987@reviews-vm2.apache.org>
Reply-To: Jie Yu <yujie.jay@gmail.com>
archived-at: Thu, 23 Nov 2017 05:27:47 -0000

--===============7461391204900782936==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62762/#review191779
-----------------------------------------------------------


src/resource_provider/local.cpp
Lines 35-40 (patched)
<https://reviews.apache.org/r/62762/#comment269692>

    see my comments below, you probably do not need this struct anymore.


src/resource_provider/local.cpp
Lines 45 (patched)
<https://reviews.apache.org/r/62762/#comment269690>

    We try to avoid non-POD (plain old data) global variables because it'll cause issues during exit (see google style guide).
    
    So I'll make this a helper function.


src/resource_provider/local.cpp
Lines 49 (patched)
<https://reviews.apache.org/r/62762/#comment269691>

    Do we still need this? It looks to me that the current naming scheme makes it so that you don't have to customize it for each LRP?


- Jie Yu


On Nov. 22, 2017, 3:10 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62762/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 3:10 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8100
>     https://issues.apache.org/jira/browse/MESOS-8100
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `LocalResourceProvider::principal()` function takes a
> `ResourceProviderInfo` and generates a principal with the following
> claim:
> 
>   {"cid_prefix", <type-with-dots-replaced-by-dashes>-<name>--}
> 
> For example, for resource provider with type
> 'org.apache.mesos.rp.local.storage' and name 'foo', the claim would be:
> 
>   {"cid_prefix", "org-apache-mesos-rp-local-storage-foo--"}
> 
> In the future, we could add more claims for authorizing other
> operations, such as authorization for Resource Provider API.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f 
>   src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da 
>   src/resource_provider/storage/provider.hpp 6de88c2329b358fcf48bc39ddda0132170991c3c 
>   src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f 
> 
> 
> Diff: https://reviews.apache.org/r/62762/diff/8/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


--===============7461391204900782936==--