Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 34064200D42 for ; Fri, 17 Nov 2017 23:35:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 326F4160BFB; Fri, 17 Nov 2017 22:35:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 786DA160BE6 for ; Fri, 17 Nov 2017 23:35:52 +0100 (CET) Received: (qmail 9383 invoked by uid 500); 17 Nov 2017 22:35:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9372 invoked by uid 99); 17 Nov 2017 22:35:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Nov 2017 22:35:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 968C318084E; Fri, 17 Nov 2017 22:35:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.187 X-Spam-Level: **** X-Spam-Status: No, score=4.187 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gmXVBc4mczsF; Fri, 17 Nov 2017 22:35:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CAEC85F239; Fri, 17 Nov 2017 22:35:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 255A4E0662; Fri, 17 Nov 2017 22:35:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1EC87C4031F; Fri, 17 Nov 2017 22:35:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1815195684449539046==" MIME-Version: 1.0 Subject: Re: Review Request 63859: Windows: Fixed mock signal values in stout. From: Akash Gupta To: John Kordich , Andrew Schwartzmeyer Cc: Akash Gupta , mesos Date: Fri, 17 Nov 2017 22:35:48 -0000 Message-ID: <20171117223548.12331.86057@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63859/ X-Sender: Akash Gupta References: <20171116181719.60262.65597@reviews-vm2.apache.org> In-Reply-To: <20171116181719.60262.65597@reviews-vm2.apache.org> Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos archived-at: Fri, 17 Nov 2017 22:35:53 -0000 --===============1815195684449539046== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/ ----------------------------------------------------------- (Updated Nov. 17, 2017, 10:35 p.m.) Review request for mesos, Andrew Schwartzmeyer and John Kordich. Summary (updated) ----------------- Windows: Fixed mock signal values in stout. Bugs: MESOS-7342 https://issues.apache.org/jira/browse/MESOS-7342 Repository: mesos Description (updated) ------- Also fixed the WEXITSTATUS macro to cast the exit code instead of bit-masking it, since Windows exit codes are 32 bit unsigned ints. Diffs (updated) ----- 3rdparty/stout/include/stout/windows.hpp 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 Diff: https://reviews.apache.org/r/63859/diff/2/ Changes: https://reviews.apache.org/r/63859/diff/1-2/ Testing ------- See https://reviews.apache.org/r/63862/ for test results. Thanks, Akash Gupta --===============1815195684449539046==--