Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D3124200D42 for ; Fri, 17 Nov 2017 15:02:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D1DF6160C0A; Fri, 17 Nov 2017 14:02:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 22910160BF8 for ; Fri, 17 Nov 2017 15:02:54 +0100 (CET) Received: (qmail 2054 invoked by uid 500); 17 Nov 2017 14:02:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 2040 invoked by uid 99); 17 Nov 2017 14:02:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Nov 2017 14:02:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 37A6AC67AC; Fri, 17 Nov 2017 14:02:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xizmP6DUwitK; Fri, 17 Nov 2017 14:02:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B382F5FC55; Fri, 17 Nov 2017 14:02:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0CE13E0295; Fri, 17 Nov 2017 14:02:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 074EEC4031F; Fri, 17 Nov 2017 14:02:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3336611290222988870==" MIME-Version: 1.0 Subject: Review Request 63915: Reduced tasks copying during agent reregistration. From: Dmitry Zhuk To: Benjamin Mahler , Michael Park Cc: Dmitry Zhuk , mesos Date: Fri, 17 Nov 2017 14:02:47 -0000 Message-ID: <20171117140247.44333.73992@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dmitry Zhuk X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63915/ X-Sender: Dmitry Zhuk Reply-To: Dmitry Zhuk X-ReviewRequest-Repository: mesos archived-at: Fri, 17 Nov 2017 14:02:56 -0000 --===============3336611290222988870== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972 https://issues.apache.org/jira/browse/MESOS-6972 Repository: mesos Description ------- Tasks can be moved into master's internal data structures from message to save some cycles on copying the data. Diffs ----- src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f Diff: https://reviews.apache.org/r/63915/diff/1/ Testing ------- make check Ran benchmark with `--enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --enable-last-in-first-out-fixed-size-semaphore` `./mesos-tests.sh --benchmark --gtest_filter=AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.*` On 2608c0b8f62a9359d3d23e1724b6e91f316cfc76 (includes protobuf-3.5.0): ``` [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 Starting reregistration for all agents Reregistered 2000 agents with a total of 100000 running tasks and 100000 completed tasks in 16.202206916secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 (30065 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 Starting reregistration for all agents Reregistered 2000 agents with a total of 200000 running tasks and 0 completed tasks in 30.509804836secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 (57145 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 Starting reregistration for all agents Reregistered 20000 agents with a total of 100000 running tasks and 0 completed tasks in 22.581999748secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 (39629 ms) ``` On this chain of patches: ``` [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 Starting reregistration for all agents Reregistered 2000 agents with a total of 100000 running tasks and 100000 completed tasks in 8.456615936secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 (22659 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 Starting reregistration for all agents Reregistered 2000 agents with a total of 200000 running tasks and 0 completed tasks in 15.09102354secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 (43828 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 Starting reregistration for all agents Reregistered 20000 agents with a total of 100000 running tasks and 0 completed tasks in 16.122729767secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 (33182 ms) ``` Thanks, Dmitry Zhuk --===============3336611290222988870==--