Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0194B200D4E for ; Fri, 17 Nov 2017 00:10:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F41B5160BF4; Thu, 16 Nov 2017 23:10:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 453C8160BEA for ; Fri, 17 Nov 2017 00:10:44 +0100 (CET) Received: (qmail 19154 invoked by uid 500); 16 Nov 2017 23:10:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 19143 invoked by uid 99); 16 Nov 2017 23:10:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 23:10:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 658531808A7; Thu, 16 Nov 2017 23:10:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.199 X-Spam-Level: *** X-Spam-Status: No, score=3.199 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Pk3aXzdWSBsj; Thu, 16 Nov 2017 23:10:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 18B5C5FBB1; Thu, 16 Nov 2017 23:10:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6C022E04F4; Thu, 16 Nov 2017 23:10:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6323DC401B6; Thu, 16 Nov 2017 23:10:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5410331416860383293==" MIME-Version: 1.0 Subject: Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows. From: Michael Park To: Gaston Kleiman , Michael Park , Andrew Schwartzmeyer , Joseph Wu , Li Li , John Kordich Cc: Jeff Coffler , mesos Date: Thu, 16 Nov 2017 23:10:39 -0000 Message-ID: <20171116231039.60262.39685@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63253/ X-Sender: Michael Park X-ReviewBoard-ShipIt: 1 References: <20171108003727.26136.34717@reviews-vm2.apache.org> In-Reply-To: <20171108003727.26136.34717@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Michael Park X-ReviewRequest-Repository: mesos archived-at: Thu, 16 Nov 2017 23:10:45 -0000 --===============5410331416860383293== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review191265 ----------------------------------------------------------- Ship it! Ship It! - Michael Park On Nov. 7, 2017, 4:37 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 4:37 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gaston Kleiman, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/5/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the modified tests ran properly. > > > Thanks, > > Jeff Coffler > > --===============5410331416860383293==--