Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 25D65200D3C for ; Tue, 14 Nov 2017 22:41:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 240FE160BF4; Tue, 14 Nov 2017 21:41:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 68AD4160BD7 for ; Tue, 14 Nov 2017 22:41:23 +0100 (CET) Received: (qmail 15386 invoked by uid 500); 14 Nov 2017 21:41:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 15375 invoked by uid 99); 14 Nov 2017 21:41:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 21:41:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8BCB21807A3; Tue, 14 Nov 2017 21:41:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id K6azJWdjamdg; Tue, 14 Nov 2017 21:41:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F29705FD1B; Tue, 14 Nov 2017 21:41:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9A816E00C9; Tue, 14 Nov 2017 21:41:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 91F9BC401B6; Tue, 14 Nov 2017 21:41:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7267718805196514615==" MIME-Version: 1.0 Subject: Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container. From: Chun-Hung Hsiao To: Jie Yu , Joseph Wu , Gilbert Song Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Chun-Hung Hsiao , mesos Date: Tue, 14 Nov 2017 21:41:19 -0000 Message-ID: <20171114214119.16898.38876@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63680/ X-Sender: Chun-Hung Hsiao References: <20171110021332.37791.50123@reviews-vm2.apache.org> In-Reply-To: <20171110021332.37791.50123@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/container_daemon.hpp X-ReviewBoard-Diff-For: src/slave/container_daemon.cpp Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos archived-at: Tue, 14 Nov 2017 21:41:24 -0000 --===============7267718805196514615== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ ----------------------------------------------------------- (Updated Nov. 14, 2017, 9:41 p.m.) Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu. Bugs: MESOS-8183 https://issues.apache.org/jira/browse/MESOS-8183 Repository: mesos Description (updated) ------- The `ContanierDaemon` class is responsible to monitor if a long-running service running in a standalone container, and restart the service container after it exits. It takes the following hook functions: * `postStartHook`: called after the container is launched every time. * `postStopHook`: called after the container exits every time. `ContainerDaemon` does not manage the lifecycle of the contanier it monitors, so the container persists across `ContainerDaemon`s. However, it provides a `terminate()` method to completely shutdown the service container. Diffs (updated) ----- src/Makefile.am 955f01a665019d7750980ff16f126ad63b524594 src/slave/container_daemon.hpp PRE-CREATION src/slave/container_daemon.cpp PRE-CREATION Diff: https://reviews.apache.org/r/63680/diff/3/ Changes: https://reviews.apache.org/r/63680/diff/2-3/ Testing ------- Thanks, Chun-Hung Hsiao --===============7267718805196514615==--