Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5C767200D33 for ; Wed, 8 Nov 2017 23:08:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5AE55160BDA; Wed, 8 Nov 2017 22:08:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A36D71609E0 for ; Wed, 8 Nov 2017 23:08:09 +0100 (CET) Received: (qmail 47554 invoked by uid 500); 8 Nov 2017 22:08:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47543 invoked by uid 99); 8 Nov 2017 22:08:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 22:08:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CA515D2F7A; Wed, 8 Nov 2017 22:08:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jZQa4QD-avyi; Wed, 8 Nov 2017 22:08:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7360A5F4E5; Wed, 8 Nov 2017 22:08:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0CC5FE05B7; Wed, 8 Nov 2017 22:08:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 072E8C40449; Wed, 8 Nov 2017 22:08:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0798299271388513756==" MIME-Version: 1.0 Subject: Re: Review Request 63652: Added d_type check in containerizer backend validation. From: Mesos Reviewbot Windows To: Gilbert Song Cc: Mesos Reviewbot Windows , Meng Zhu , mesos Date: Wed, 08 Nov 2017 22:08:05 -0000 Message-ID: <20171108220805.19938.82124@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63652/ X-Sender: Mesos Reviewbot Windows References: <20171108184648.19938.84384@reviews-vm2.apache.org> In-Reply-To: <20171108184648.19938.84384@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos archived-at: Wed, 08 Nov 2017 22:08:10 -0000 --===============0798299271388513756== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190499 ----------------------------------------------------------- PASS: Mesos patch 63652 was successfully built and tested. Reviews applied: `['63652']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652 - Mesos Reviewbot Windows On Nov. 8, 2017, 6:46 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63652/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 6:46 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8121 > https://issues.apache.org/jira/browse/MESOS-8121 > > > Repository: mesos > > > Description > ------- > > In unified containerizer, the d_type cannot be 1 > if we are using the overlay fs backend. > In particular, XFS can be mounted with ftype = 0 > which renders d_type == 0. Raise error if user > specifies overlayfs as backend. Fallback to other > backends in the default case and raise a warning. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b > src/slave/containerizer/mesos/provisioner/utils.hpp 5b6c162fe4ade16131b2207d707e76228b0ec51a > src/slave/containerizer/mesos/provisioner/utils.cpp 7fd7315dda99f49f967a665afe27c8db7835c04c > > > Diff: https://reviews.apache.org/r/63652/diff/2/ > > > Testing > ------- > > Manually tested slave creation with default and overlayfs backends on XFS based work_dir with different ftype mount options. > > > Thanks, > > Meng Zhu > > --===============0798299271388513756==--