mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63779: Windows: Fixed `SlaveReregisterTaskExecutorIds` test.
Date Thu, 30 Nov 2017 23:50:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63779/#review192401
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On Nov. 30, 2017, 11:41 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63779/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 11:41 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Alexander Rukletsov, Jie Yu, John Kordich, Joseph
Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Similar to the check tests, with the `cpu` hard cap enabled, the task in
> this test failed with an OOM error because PowerShell requires more
> resources than were being allocated. The `defaultTaskResourcesString`
> was moved into the `MesosTests` base class so that any test creating a
> task can use these default resources, instead of a hard-coded string.
> Additionally, the resources allocated by default for an agent were
> increased so that multiple tasks can be run simultaneously (as this test
> does).
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp f14b81aa06f6e0acbc2c3d4c65b0443d09127e78 
>   src/tests/master_slave_reconciliation_tests.cpp d2501f5c140290fd4de7e7a286b51f7ec05ae6e4

>   src/tests/mesos.hpp c871878fb1e2ea2716da6232ea0ed766399068b6 
> 
> 
> Diff: https://reviews.apache.org/r/63779/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` passed on CentOS 7
> 
> `ctest -C Debug` passed on Windows 10
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message