mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63843: Implemented a test of offer operation reconcilation.
Date Thu, 30 Nov 2017 01:56:37 GMT


> On Nov. 29, 2017, 3:09 a.m., Jie Yu wrote:
> > src/tests/slave_tests.cpp
> > Lines 8900-8923 (patched)
> > <https://reviews.apache.org/r/63843/diff/6/?file=1902759#file1902759line8900>
> >
> >     It'll be nice to move this logic here to MockResourceProvider::operationFailed
and call `Invoke(...)` in the EXPECT above.

either drop or address?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63843/#review192103
-----------------------------------------------------------


On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63843/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Whenever a speculated operation fails in a resource provider, we
> expect the agent to trigger a 'UpdateSlaveMessage' to the master so it
> can rollback its agent state. This patch adds such a test.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c 
> 
> 
> Diff: https://reviews.apache.org/r/63843/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message