mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.
Date Wed, 29 Nov 2017 22:47:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63810/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 2:47 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Moved implementation of `fullpath` because now `create_symbolic_link` does not need it.


Bugs: MESOS-6735
    https://issues.apache.org/jira/browse/MESOS-6735


Repository: mesos


Description
-------

This explicitly does not check for existence, nor does it follow
symlinks. It simply normalizes a given path to an absolute path. This
removes the `reparsepoint.hpp` and `symlink.hpp` dependency os
`os::realpath`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/symlink.hpp b9cf1229ec0b6c70fe9b9d358e867e91e475dfaa

  3rdparty/stout/include/stout/windows/fs.hpp d7b883ca1f3f8972e1bf9fbd211cc564c7c30f14 


Diff: https://reviews.apache.org/r/63810/diff/2/

Changes: https://reviews.apache.org/r/63810/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message