mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64176: Added a test for ContainerDaemon.
Date Wed, 29 Nov 2017 21:59:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64176/#review192172
-----------------------------------------------------------


Fix it, then Ship it!




LGTM.


src/tests/CMakeLists.txt
Lines 87 (patched)
<https://reviews.apache.org/r/64176/#comment270216>

    Most of Chun's code is not included in the CMake build, so adding this line will probably
not build.
    
    We can leave it out for now and add all the sources to CMake along with gRPC and its dependents.



src/tests/container_daemon_tests.cpp
Lines 112 (patched)
<https://reviews.apache.org/r/64176/#comment270218>

    Missing a `// USE_SSL_SOCKET`.


- Joseph Wu


On Nov. 29, 2017, 1:35 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64176/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for ContainerDaemon.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b1ed4e548fe892fcc2da5f2e06aa0f4d5e63ee73 
>   src/tests/CMakeLists.txt 8997cc0f762aa27decaa24a147a8581549a82e80 
>   src/tests/container_daemon_tests.cpp PRE-CREATION 
>   src/tests/mesos.hpp 68f78d01d2145532f6873e824fdb6e16a278daad 
>   src/tests/mesos.cpp b6daf85e2c064e4df14b6322ac6d015a69874e34 
> 
> 
> Diff: https://reviews.apache.org/r/64176/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message