mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63732: Reconciled offer operations between agent and master.
Date Wed, 29 Nov 2017 16:28:09 GMT


> On Nov. 29, 2017, 3:39 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 7108-7111 (original), 7111-7117 (patched)
> > <https://reviews.apache.org/r/63732/diff/8/?file=1902757#file1902757line7111>
> >
> >     If agent has resource provider capability, update slave message will be sent
to the master from each agent during (re)registration.
> >     
> >     As a result, the following code will be executed in master for each agent, which
is quite expensive. Is there anyway to avoid that massive messages? either from the agent
side to not send it if there's no change, or avoid the following code in the master if there
is no change.

I added code to both the agent side and the master side here to either avoid sending the message
or not fully process it in case no change is detected. Unfortunately it is not possible to
only process part of the message in the master, so we either can ignore noop messages, or
need to processes them completely.


> On Nov. 29, 2017, 3:39 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Line 7114 (original), 7387-7399 (patched)
> > <https://reviews.apache.org/r/63732/diff/8/?file=1902757#file1902757line7387>
> >
> >     This logic should be in `removeOfferOperation`

None of the existing master `addOfferOperation` functions currently modify the allocator.
I'd suggest to maintain allocator state externally for now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63732/#review192090
-----------------------------------------------------------


On Nov. 29, 2017, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63732/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/63732/diff/9/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> This patch requires `protobuf::isSpeculativeOperation` from https://reviews.apache.org/r/63751/
which is _not_ part of this review chain (to avoid multiple dependent RRs).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message