mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63213: Added mount propagation support for HOST_PATH volumes.
Date Wed, 29 Nov 2017 02:45:31 GMT


> On Nov. 29, 2017, 1:39 a.m., Gilbert Song wrote:
> > Should we update the upgrades.md in a followup patch for semantic changes?

Yes, and I'll add doc too.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63213/#review192093
-----------------------------------------------------------


On Nov. 27, 2017, 4:50 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63213/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 4:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows a container to declare a host path volume such that the
> mounts under that volume can be propagated in both directions.
> Previously, all volume mounts are default to use host to container
> propagation mode.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302

>   src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 89710f75715fc7e9684d84fce61315f8093ed2dd

>   src/tests/mesos.hpp e5c2b697a4401f010a7d77ae9acb8a9cbd3846bc 
> 
> 
> Diff: https://reviews.apache.org/r/63213/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message