mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63997: Added a new allocator method to add resources to agents.
Date Tue, 28 Nov 2017 21:32:50 GMT


> On Nov. 28, 2017, 12:26 a.m., Benjamin Mahler wrote:
> > include/mesos/allocator/allocator.hpp
> > Lines 220 (patched)
> > <https://reviews.apache.org/r/63997/diff/3/?file=1901519#file1901519line220>
> >
> >     Hm.. why is this called out? I don't think a caller could depend on this for
correctness, so it seems better not to put this in the interface documentation?

I removed it here. I agree this promise here is neither useful nor needed.


> On Nov. 28, 2017, 12:26 a.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 689-718 (patched)
> > <https://reviews.apache.org/r/63997/diff/3/?file=1901522#file1901522line689>
> >
> >     Is this copied from elsewhere? If so, can you guys think about how to pull it
out like we did for `updateSlaveTotal`? Is this `trackAllocatedResources`?

This code was copied from `addSlave`. In a preceeding patch I now introduce a dedicated helper
function to track these allocated resources and simplified the code here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63997/#review191947
-----------------------------------------------------------


On Nov. 28, 2017, 10:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63997/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The added method complements 'Allocator::addSlave'. While in
> 'addSlave' the total agent resources and used resources are passed,
> the method 'addResourceProvider' added here allows to add additional,
> potentially used resources to an existing agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 
>   src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 
>   src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3

>   src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b

>   src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 
>   src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff

> 
> 
> Diff: https://reviews.apache.org/r/63997/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message