mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64000: Added generic stringification of hashmap of stringifiable types.
Date Tue, 28 Nov 2017 21:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64000/
-----------------------------------------------------------

(Updated Nov. 28, 2017, 10:32 p.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Changes
-------

Rebased, cleanup now happens in r/63997.


Summary (updated)
-----------------

Added generic stringification of hashmap of stringifiable types.


Repository: mesos


Description (updated)
-------

This patch adds generic stringification for hashmaps of stringifiable
types to stout. Related, but less generic functions are currently
implemented in both 'v1/mesos.hpp' and 'v1/type_utils.hpp'; these
implementations will be removed in a subsequent commit.


Diffs (updated)
-----

  3rdparty/stout/include/stout/hashmap.hpp faf8002f67c1385234fc18602e3cd6bdf47a3c34 


Diff: https://reviews.apache.org/r/64000/diff/2/

Changes: https://reviews.apache.org/r/64000/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message