mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63997: Added a new allocator method to add resources to agents.
Date Tue, 28 Nov 2017 21:32:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63997/
-----------------------------------------------------------

(Updated Nov. 28, 2017, 10:32 p.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
-------

Addressed comments from bmahler.


Repository: mesos


Description
-------

The added method complements 'Allocator::addSlave'. While in
'addSlave' the total agent resources and used resources are passed,
the method 'addResourceProvider' added here allows to add additional,
potentially used resources to an existing agent.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 
  src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 
  src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3 
  src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b 
  src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 
  src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff 


Diff: https://reviews.apache.org/r/63997/diff/4/

Changes: https://reviews.apache.org/r/63997/diff/3-4/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message