mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64054: Refactored offer operation handling for speculative operations.
Date Tue, 28 Nov 2017 17:01:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64054/#review192038
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 9929 (patched)
<https://reviews.apache.org/r/64054/#comment270023>

    This is unnecessary. You just created the offer operation above with OFFER_OPERATION_PENDING.
If you really want, this could be a CHECK.


- Jie Yu


On Nov. 28, 2017, 2:25 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64054/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 2:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Applying operations has been refactored out of 'addOfferOperation' and
> simplified by using 'protobuf::isSpeculativeOperation'.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 53263e499d88b906b6406c24c0dfb737e589e813 
>   src/slave/slave.cpp 6ed5c7887cf998b92cf3181b29cb6cf09cc73e61 
> 
> 
> Diff: https://reviews.apache.org/r/64054/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message