mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64014: Added default reservations in `ResourceProviderInfo`.
Date Thu, 23 Nov 2017 05:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/#review191781
-----------------------------------------------------------




include/mesos/mesos.proto
Line 1035 (original)
<https://reviews.apache.org/r/64014/#comment269697>

    Why this move? You should put this close to CSIPluginInfo and CSIPluginContianerInfo.



include/mesos/resources.hpp
Lines 65 (patched)
<https://reviews.apache.org/r/64014/#comment269695>

    2 lines apart



include/mesos/v1/mesos.proto
Line 1027 (original)
<https://reviews.apache.org/r/64014/#comment269698>

    Ditto.



src/common/type_utils.cpp
Lines 408 (patched)
<https://reviews.apache.org/r/64014/#comment269696>

    Update src/v1/mesos.cpp


- Jie Yu


On Nov. 23, 2017, 1:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64014/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 1:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `default_reservations` field is used to set up the default
> reservation stack for new resources from the resource provider.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
> 
> 
> Diff: https://reviews.apache.org/r/64014/diff/3/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message