mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 62637: Added an object approver to authorize requests from resource providers.
Date Wed, 22 Nov 2017 09:12:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62637/#review191714
-----------------------------------------------------------



Please add unit tests.

- Alexander Rojas


On Nov. 21, 2017, 2:14 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62637/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 2:14 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8100
>     https://issues.apache.org/jira/browse/MESOS-8100
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds `LocalImplicitResourceProviderObjectApprover`, which
> authorize standalone container calls from a resource provider if the
> container IDs are prefixed with the namespace string.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp 40790f5801bdde8df0e2823fc8949d00b1eaa2fb 
>   src/authorizer/local/authorizer.cpp 35bf03cfd4264e27235b355c1c7c3ff07f91af94 
>   src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f 
> 
> 
> Diff: https://reviews.apache.org/r/62637/diff/3/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message