mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 63888: Updated composing containerizer tests.
Date Mon, 20 Nov 2017 17:00:07 GMT


> On Nov. 17, 2017, 6:09 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/composing_containerizer_tests.cpp
> > Line 184 (original), 203 (patched)
> > <https://reviews.apache.org/r/63888/diff/1/?file=1894560#file1894560line203>
> >
> >     Why do you change this condition? I think the purpose of the test is to distinguish
the case where the termination future is associated with the underlying c-zer's termination
future and the case where termination promise is set to `true` in `_launch()`.

Ok, reverted.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63888/#review191373
-----------------------------------------------------------


On Nov. 16, 2017, 8:42 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63888/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 8:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7506
>     https://issues.apache.org/jira/browse/MESOS-7506
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated composing containerizer tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/composing_containerizer_tests.cpp b759ba2ec6a975a0acc391cccdcd9a5d6dda72ed

> 
> 
> Diff: https://reviews.apache.org/r/63888/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message