mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63385: Added utility functions for CSI responses and volume ID and metadata.
Date Thu, 16 Nov 2017 00:33:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63385/#review191126
-----------------------------------------------------------




src/csi/utils.cpp
Lines 41-46 (patched)
<https://reviews.apache.org/r/63385/#comment268736>

    This comparison _looks_ wrong :)
    
    You should note that the object is empty, so they must be equal.



src/csi/utils.cpp
Lines 62-71 (patched)
<https://reviews.apache.org/r/63385/#comment268733>

    Does this version of the proto have the `access_mode` field?
    
    https://github.com/container-storage-interface/spec/blob/2561947ce5899bcb80e5dbaecb99afdce66e91d4/csi.proto#L228
    
    If not, consider adding a TODO?
    
    ---
    
    Also, it might be a good idea to add a note about the Proto3 `oneof` notation which enforces
the existence of either `block` or `mount`.  I'm guessing most contributors reading through
this code might be more familiar with Proto2 rules.



src/csi/utils.cpp
Lines 125-127 (patched)
<https://reviews.apache.org/r/63385/#comment268737>

    Probably want to leave a TODO here, since `VolumeMetaData` no longer exists:
    https://github.com/container-storage-interface/spec/commit/d2bdb9177e192ecee994c549f1b166fc073ff40b


- Joseph Wu


On Oct. 27, 2017, 4:59 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63385/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 4:59 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added utility functions for CSI responses and volume ID and metadata.
> 
> 
> Diffs
> -----
> 
>   src/csi/utils.hpp PRE-CREATION 
>   src/csi/utils.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63385/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message