mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.
Date Wed, 15 Nov 2017 21:40:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62777/
-----------------------------------------------------------

(Updated Nov. 15, 2017, 9:40 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed bbannier's comment.


Bugs: MESOS-8052
    https://issues.apache.org/jira/browse/MESOS-8052


Repository: mesos


Description
-------

The protobuf hpp and cpp files for `protobuf_tests.proto` should be
built after `BUNDLED_DEPS`, not within it.


Diffs (updated)
-----

  3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 


Diff: https://reviews.apache.org/r/62777/diff/3/

Changes: https://reviews.apache.org/r/62777/diff/2-3/


Testing
-------

make -j4 check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message