mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 63731: Reconciled pending resource provider operations in agent.
Date Mon, 13 Nov 2017 22:07:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63731/#review190887
-----------------------------------------------------------




src/slave/slave.cpp
Lines 3791 (patched)
<https://reviews.apache.org/r/63731/#comment268441>

    `operation_uuid` is a required field in `OfferOperationUpdateAcknowledgementMessage`.



src/slave/slave.cpp
Lines 3800-3803 (patched)
<https://reviews.apache.org/r/63731/#comment268443>

    Am I correct in thinking that we usually don't use quotes around IDs that we generate
ourselves in Mesos? We may be able to remove the quotes around `operation_uuid` here.



src/slave/slave.cpp
Lines 3814 (patched)
<https://reviews.apache.org/r/63731/#comment268449>

    This currently assumes that all operation update acknowledgements are for terminal operation
updates - is the plan to write it this way for now, and then update later if we add intermediate,
non-terminal operation states?



src/slave/slave.cpp
Lines 6777 (patched)
<https://reviews.apache.org/r/63731/#comment268451>

    Note that in `addOfferOperation()`, we do `CHECK_SOME(uuid)` after grabbing `operation.operation_uuid`.
    
    I'm not sure that always checking the error case is necessary when the messages are generated
by Mesos, but I mention it here because in the `offerOperationUpdateAcknowledgement` handler,
you're performing an `if (operationUuid.isError())` check on a UUID out of a message from
master, so the treatment of errors seems inconsistent.


- Greg Mann


On Nov. 13, 2017, 6:33 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63731/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2017, 6:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When resource providers update their state they send a list of
> pending or unacknowledged operations to the agent. This patch add
> tracking for such operations to the agent. The agent can then forward
> these operations to the master, e.g., for calculating the unused
> resources behind an agent.
> 
> We track an operation until we either receive a updated list of
> pending or unacknowledged operations from a resource provider, or
> until we see an acknowledgement from a framework. This keeps the list
> of operations bounded and ensures that we maintain the latest
> information in the agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 7cb6661b55fb5437a1ffc447f974076aadd1eced 
> 
> 
> Diff: https://reviews.apache.org/r/63731/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`, still need to implement dedicated tests.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message