mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 63703: Linted controllers.js.
Date Fri, 10 Nov 2017 13:16:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63703/#review190708
-----------------------------------------------------------



I still get some warnings when I run the linter over this. We should put exceptions in the
linter to ignore these cases as they come up when we have an argument that is passed in but
never used.

- Kevin Klues


On Nov. 9, 2017, 4:35 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63703/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 4:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a default default case, removes unary
> operator '++' and an unnecessary semicolon.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js e753709f59d1cc5deafb632a4feab453964f1dae

> 
> 
> Diff: https://reviews.apache.org/r/63703/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> $ python support/mesos-style.py src/webui/master/static/js/controllers.js
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message