mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Date Tue, 07 Nov 2017 15:39:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review190322
-----------------------------------------------------------




src/python/cli_new/lib/cli/util.py
Lines 258 (patched)
<https://reviews.apache.org/r/62938/#comment267611>

    We don't need this if statement. At a minimum we will get a "{}" back from the zk.get()
call (which will make this if statement always return true.



src/python/cli_new/lib/cli/util.py
Lines 266 (patched)
<https://reviews.apache.org/r/62938/#comment267614>

    Let's pull the zk.stop() up above the if statememnt here and wrap it in a try/except block.
    
    Then we can do the if/return followed immediately by the raise on failure.



src/python/cli_new/lib/cli/util.py
Lines 270 (patched)
<https://reviews.apache.org/r/62938/#comment267607>

    Can this throw an exception?


- Kevin Klues


On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2017, 4:52 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8012
>     https://issues.apache.org/jira/browse/MESOS-8012
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
> 
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b 
>   src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a 
>   src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653 
> 
> 
> Diff: https://reviews.apache.org/r/62938/diff/4/
> 
> 
> Testing
> -------
> 
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands
successfully.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message