> On Nov. 6, 2017, 8:07 p.m., Benjamin Bannier wrote:
> > src/master/master.cpp
> > Lines 9645 (patched)
> > <https://reviews.apache.org/r/63592/diff/1/?file=1882127#file1882127line9645>
> >
> > Should we `CHECK(operation->has_latest_status())` and somewhere above?
`latest_status` in `OfferOperation` is required.
> On Nov. 6, 2017, 8:07 p.m., Benjamin Bannier wrote:
> > src/master/master.cpp
> > Lines 9665 (patched)
> > <https://reviews.apache.org/r/63592/diff/1/?file=1882127#file1882127line9665>
> >
> > Should this be `UUID::fromBytes`?
>
> Jie Yu wrote:
> good catch! Thanks!
I fix the other incorrect fromString as well.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63592/#review190209
-----------------------------------------------------------
On Nov. 6, 2017, 6:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63592/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2017, 6:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented updateOfferOperation in the master.
>
>
> Diffs
> -----
>
> src/master/master.cpp f349fec8b61fa424c63d77253b6ab3ded08c8cdb
>
>
> Diff: https://reviews.apache.org/r/63592/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|