mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63485: Added initial code for offer operation status update in master.
Date Mon, 06 Nov 2017 18:10:18 GMT


> On Nov. 6, 2017, 3:29 p.m., Benjamin Bannier wrote:
> > src/master/master.cpp
> > Lines 5161-5162 (original), 5164-5165 (patched)
> > <https://reviews.apache.org/r/63485/diff/1/?file=1878383#file1878383line5166>
> >
> >     I am not sure why we went from a managed ptr to a raw pointer here and below.
It e.g., seems we now leak `offerOperation`s (this patch just adds `new`, but no matching
`delete`).
> >     
> >     Could we just keep using `Owned<OfferOperation>` here?
> 
> Jie Yu wrote:
>     The 'deletion' will be addressed in the following patches (in `removeOfferOperation`).
The reason for a raw pointer here is because Framework needs to maintain a hashmap to `OfferOperation`
pointer too. I made it consistent with Task.

I'll probably followup with a patch to change raw pointer to `shared_ptr`


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63485/#review190162
-----------------------------------------------------------


On Nov. 1, 2017, 11:18 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63485/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 11:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann,
and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial code for offer operation status update in master.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 
>   src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
> 
> 
> Diff: https://reviews.apache.org/r/63485/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message