mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.
Date Fri, 03 Nov 2017 18:41:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190044
-----------------------------------------------------------




src/slave/slave.hpp
Lines 574 (patched)
<https://reviews.apache.org/r/63519/#comment267297>

    Can you re-use slave::Capabilities in protobuf_utils.cpp|hpp?
    
    Also, given that this is already under `Slave`, i'd just call it `capabilities`. (more
consistent with Framework::capabilities).



src/slave/slave.cpp
Lines 8441-8453 (patched)
<https://reviews.apache.org/r/63519/#comment267299>

    Can you move this to the flag validation?


- Jie Yu


On Nov. 3, 2017, 4:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c 
>   src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba 
>   src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a 
> 
> 
> Diff: https://reviews.apache.org/r/63519/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63496/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message